The professional identities of journalism undergraduate students and the affecting factors are analyzed based on a survey of journalism undergraduate students from six universities in Shanghai. This study also compares the difference between three types of journalism students, and focuses on the effect of journalism education, including on-campus education and off-campus internship to students’ professional identities. It shows that journalism undergraduate students’ professional identity is generally low. There are signifcant differences in professional identities between three types of journalism undergraduate students. Individual factors such as gender, grade and family in?uence are not the main causes of the differences in journalism undergraduate students’ professional identities. On-campus education and off-campus internship become complementary, obviously promoting the journalism undergraduate students’ professional identities.